Skip to content

fix: ddp-streamer restart keeping opened connections#35195

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
fix-ddp-streamer-restart
Feb 14, 2025
Merged

fix: ddp-streamer restart keeping opened connections#35195
kodiakhq[bot] merged 6 commits intodevelopfrom
fix-ddp-streamer-restart

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 12, 2025 •
edited by ggazzo
Loading

The fix will be using a random id for each ddp-streamer instance so in a restart a new id will be created, causing the old connections being pruned by the existing code that prunes connections from non-existent instances.

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1453

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 12, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47f8014

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (f89741d) to head (47f8014).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35195   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68163    68163           
  Branches     15123    15123           
========================================
  Hits         40517    40517           
  Misses       24990    24990           
  Partials      2656     2656
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego marked this pull request as ready for review February 12, 2025 23:27
@sampaiodiego sampaiodiego requested a review from a team as a code owner February 12, 2025 23:27
KevLehman
KevLehman requested changes Feb 13, 2025
View reviewed changes
@sampaiodiego @KevLehman
Apply suggestions from code review
2803d14 
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
@sampaiodiego sampaiodiego added this to the 7.4.0 milestone Feb 13, 2025
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Feb 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2025
@kodiakhq kodiakhq bot merged commit a1d3faa into develop Feb 14, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix-ddp-streamer-restart branch February 14, 2025 20:14
@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 14, 2025

/patch

dionisio-bot bot pushed a commit that referenced this pull request Feb 14, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
331aa26
@dionisio-bot dionisio-bot bot mentioned this pull request Feb 14, 2025
Merged
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 14, 2025

Pull request #35220 added to Project: "Patch 7.3.2"

@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.2.3

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.2.3-35195
git cherry-pick a1d3faa0e2ee9c347e45e4e75a211983ba702820
// solve the conflict
git push

after that just run /backport 7.2.3 again

sampaiodiego added a commit that referenced this pull request Feb 17, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
f84a201
@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.2.3

@dionisio-bot dionisio-bot bot mentioned this pull request Feb 17, 2025
Merged
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Pull request #35241 added to Project: "Patch 7.2.3"

@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.1.3

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.1.3-35195
git cherry-pick a1d3faa0e2ee9c347e45e4e75a211983ba702820
// solve the conflict
git push

after that just run /backport 7.1.3 again

sampaiodiego added a commit that referenced this pull request Feb 17, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
23f2d24
@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.1.3

@dionisio-bot dionisio-bot bot mentioned this pull request Feb 17, 2025
Merged
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Pull request #35242 added to Project: "Patch 7.1.3"

@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.0.7

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.0.7-35195
git cherry-pick a1d3faa0e2ee9c347e45e4e75a211983ba702820
// solve the conflict
git push

after that just run /backport 7.0.7 again

sampaiodiego added a commit that referenced this pull request Feb 17, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
8374aa9
@sampaiodiego
Copy link
Member Author

sampaiodiego commented Feb 17, 2025

/backport 7.0.7

@dionisio-bot dionisio-bot bot mentioned this pull request Feb 17, 2025
Merged
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

Pull request #35243 added to Project: "Patch 7.0.7"

sampaiodiego added a commit that referenced this pull request Feb 18, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
e600f70
sampaiodiego added a commit that referenced this pull request Feb 18, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
3da05b8
sampaiodiego added a commit that referenced this pull request Feb 18, 2025
@sampaiodiego
fix: ddp-streamer restart keeping opened connections (#35195)
bde258d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardogarim ricardogarim ricardogarim approved these changes

@KevLehman KevLehman KevLehman approved these changes

+1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sampaiodiego @ricardogarim @KevLehman @MarcosSpessatto